3 Star 0 Fork 10

src-openEuler/rubygem-activerecord

加入 Gitee
与超过 1200万 开发者一起发现、参与优秀开源项目,私有仓库也完全免费 :)
免费加入
文件
该仓库未声明开源许可证文件(LICENSE),使用请关注具体项目描述及其代码上游依赖。
克隆/下载
rubygem-activerecord-7.0.4-remove-require-pathname-from-drop-method-tests.patch 3.68 KB
一键复制 编辑 原始数据 按行查看 历史
lyn 提交于 2023-08-18 09:52 +08:00 . Upgrade to version 7.0.7
From e708599c85226e9ad107ebdad09a9e31f1b5388a Mon Sep 17 00:00:00 2001
From: Nicolas Iragorri Dominguez
<nicolasiragorridominguez@Nicolass-Mac-Studio.local>
Date: Tue, 27 Dec 2022 01:24:19 +0100
Subject: [PATCH] [issue-46741] remove `require pathname` from `drop` method
---
.../test/cases/tasks/sqlite_rake_test.rb | 42 +++++++------------
diff --git a/activerecord/test/cases/tasks/sqlite_rake_test.rb b/activerecord/test/cases/tasks/sqlite_rake_test.rb
index 98257867aa773..9b534b88220bd 100644
--- a/activerecord/test/cases/tasks/sqlite_rake_test.rb
+++ b/activerecord/test/cases/tasks/sqlite_rake_test.rb
@@ -72,15 +72,17 @@ def test_db_create_with_error_prints_message
class SqliteDBDropTest < ActiveRecord::TestCase
def setup
+ @root = "/rails/root"
@database = "db_create.sqlite3"
+ @database_root = File.join(@root, @database)
@configuration = {
"adapter" => "sqlite3",
"database" => @database
}
- @path = Class.new do
- def to_s; "/absolute/path" end
- def absolute?; true end
- end.new
+ @configuration_root = {
+ "adapter" => "sqlite3",
+ "database" => @database_root
+ }
$stdout, @original_stdout = StringIO.new, $stdout
$stderr, @original_stderr = StringIO.new, $stderr
@@ -90,45 +92,33 @@ def teardown
$stdout, $stderr = @original_stdout, @original_stderr
end
- def test_creates_path_from_database
- assert_called_with(Pathname, :new, [@database], returns: @path) do
- ActiveRecord::Tasks::DatabaseTasks.drop @configuration, "/rails/root"
+ def test_checks_db_dir_is_absolute
+ assert_called_with(File, :absolute_path?, [@database], returns: false) do
+ ActiveRecord::Tasks::DatabaseTasks.drop @configuration, @root
end
end
def test_removes_file_with_absolute_path
- Pathname.stub(:new, @path) do
- assert_called_with(FileUtils, :rm, ["/absolute/path"]) do
- ActiveRecord::Tasks::DatabaseTasks.drop @configuration, "/rails/root"
- end
+ assert_called_with(FileUtils, :rm, [@database_root]) do
+ ActiveRecord::Tasks::DatabaseTasks.drop @configuration_root, @root
end
end
def test_generates_absolute_path_with_given_root
- Pathname.stub(:new, @path) do
- @path.stub(:absolute?, false) do
- assert_called_with(File, :join, ["/rails/root", @path],
- returns: "/former/relative/path"
- ) do
- ActiveRecord::Tasks::DatabaseTasks.drop @configuration, "/rails/root"
- end
- end
+ assert_called_with(File, :join, [@root, @database], returns: "#{@root}/#{@database}") do
+ ActiveRecord::Tasks::DatabaseTasks.drop @configuration, @root
end
end
def test_removes_file_with_relative_path
- File.stub(:join, "/former/relative/path") do
- @path.stub(:absolute?, false) do
- assert_called_with(FileUtils, :rm, ["/former/relative/path"]) do
- ActiveRecord::Tasks::DatabaseTasks.drop @configuration, "/rails/root"
- end
- end
+ assert_called_with(FileUtils, :rm, [@database_root]) do
+ ActiveRecord::Tasks::DatabaseTasks.drop @configuration, @root
end
end
def test_when_db_dropped_successfully_outputs_info_to_stdout
FileUtils.stub(:rm, nil) do
- ActiveRecord::Tasks::DatabaseTasks.drop @configuration, "/rails/root"
+ ActiveRecord::Tasks::DatabaseTasks.drop @configuration, @root
assert_equal "Dropped database '#{@database}'\n", $stdout.string
end
Loading...
马建仓 AI 助手
尝试更多
代码解读
代码找茬
代码优化
1
https://gitee.com/src-openeuler/rubygem-activerecord.git
git@gitee.com:src-openeuler/rubygem-activerecord.git
src-openeuler
rubygem-activerecord
rubygem-activerecord
master

搜索帮助

371d5123 14472233 46e8bd33 14472233